-
Notifications
You must be signed in to change notification settings - Fork 4
feat(ISSUE-1231): missing owner label metric and alert #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On-behalf-of: @SAP krzysztof.zagorski@sap.com
…s to metrics import On-behalf-of: @SAP krzysztof.zagorski@sap.com
On-behalf-of: @SAP krzysztof.zagorski@sap.com
On-behalf-of: @SAP krzysztof.zagorski@sap.com
On-behalf-of: @SAP krzysztof.zagorski@sap.com
…orts On-behalf-of: @SAP krzysztof.zagorski@sap.com
On-behalf-of: @SAP krzysztof.zagorski@sap.com
On-behalf-of: @SAP krzysztof.zagorski@sap.com
…ugin and cluster controllers On-behalf-of: @SAP krzysztof.zagorski@sap.com
…nding controllers On-behalf-of: @SAP krzysztof.zagorski@sap.com
On-behalf-of: @SAP krzysztof.zagorski@sap.com
On-behalf-of: @SAP krzysztof.zagorski@sap.com
On-behalf-of: @SAP krzysztof.zagorski@sap.com
IvoGoman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to unify the metrics related code in dedicated files across all controllers.
The metrics/plugin_metrics.go is a special case. It was created to update metrics in both helm and internal/controller/plugin packages.
There seems to be no reuse between controllers for the other files, so I would suggest to keep the metrics in a metrics.go file in the same package as the controller.
For the shared metrics, it might be good to combine them in a internal/util/metrics.go file. So we can keep metrics local to where they are being emitted and only move the shared functions out to the shared location.
Description
This PR adds a resource-agnostic metric
greenhouse_owned_by_label_missingwith Prometheus alert.It refactors all the metrics to be in the internal metrics package.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist