Skip to content

Conversation

@IvoGoman
Copy link
Contributor

@IvoGoman IvoGoman commented Sep 4, 2025

Description

the metric's namespace is always the greenhouse namespace. this is invalid since the labelset for the metrics are the same

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

the metric's namespace is always the greenhouse namespace.
this is invalid since the labelset for the metrics are the same
@IvoGoman IvoGoman requested a review from a team as a code owner September 4, 2025 15:16
@IvoGoman IvoGoman merged commit 8d4c521 into main Sep 5, 2025
9 checks passed
@IvoGoman IvoGoman deleted the fix/org-alerts branch September 5, 2025 07:21
cloud-operator-bot bot pushed a commit that referenced this pull request Sep 5, 2025
the metric's namespace is always the greenhouse namespace.
this is invalid since the labelset for the metrics are the same

(cherry picked from commit 8d4c521)
@cloud-operator-bot
Copy link
Contributor

Successfully created backport PR for release/v0.6:

IvoGoman added a commit that referenced this pull request Sep 5, 2025
the metric's namespace is always the greenhouse namespace.
this is invalid since the labelset for the metrics are the same

(cherry picked from commit 8d4c521)

Co-authored-by: IvoGoman <ivo.gosemann@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants