Skip to content

fix(plugins): rework expression evaluation to work with mirrors#1638

Merged
IvoGoman merged 1 commit intomainfrom
feat/plugins-flux-mirror
Dec 8, 2025
Merged

fix(plugins): rework expression evaluation to work with mirrors#1638
IvoGoman merged 1 commit intomainfrom
feat/plugins-flux-mirror

Conversation

@IvoGoman
Copy link
Copy Markdown
Contributor

@IvoGoman IvoGoman commented Dec 4, 2025

Description

There was an issue with templating the Helm Chart for a Plugin that uses Expressions. This change adds a new function helm.TemplateHelmChartFromPluginOptionValues that allows templating from PluginOptions that have the Expressions already resolved. This way the expressions do not need to be resolved using the existing template functions

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@IvoGoman IvoGoman requested a review from a team as a code owner December 4, 2025 14:27
@IvoGoman IvoGoman force-pushed the feat/plugins-flux-mirror branch from a3e74a5 to 22c4e9d Compare December 4, 2025 14:28
There was an issue with templating the Helm Chart for a
Plugin that uses Expressions. This change adds a new function
helm.TemplateHelmChartFromPluginOptionValues that allows
templating from PluginOptions that have the Expressions already resolved.
This way the expressions do not need to be resolved using the existing template functions
@IvoGoman IvoGoman force-pushed the feat/plugins-flux-mirror branch from 22c4e9d to 4928309 Compare December 8, 2025 13:05
@IvoGoman IvoGoman merged commit 9874fa9 into main Dec 8, 2025
22 of 23 checks passed
@IvoGoman IvoGoman deleted the feat/plugins-flux-mirror branch December 8, 2025 14:35
@github-project-automation github-project-automation bot moved this from Sprint Backlog to Done in Greenhouse Core Roadmap Dec 9, 2025
@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants