fix(plugins): rework expression evaluation to work with mirrors#1638
Merged
fix(plugins): rework expression evaluation to work with mirrors#1638
Conversation
a3e74a5 to
22c4e9d
Compare
abhijith-darshan
approved these changes
Dec 5, 2025
mikolajkucinski
approved these changes
Dec 5, 2025
There was an issue with templating the Helm Chart for a Plugin that uses Expressions. This change adds a new function helm.TemplateHelmChartFromPluginOptionValues that allows templating from PluginOptions that have the Expressions already resolved. This way the expressions do not need to be resolved using the existing template functions
22c4e9d to
4928309
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was an issue with templating the Helm Chart for a Plugin that uses Expressions. This change adds a new function helm.TemplateHelmChartFromPluginOptionValues that allows templating from PluginOptions that have the Expressions already resolved. This way the expressions do not need to be resolved using the existing template functions
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist