fix(idproxy): initialize signer algorithm in dex server#1870
Merged
abhijith-darshan merged 1 commit intomainfrom Mar 26, 2026
Merged
fix(idproxy): initialize signer algorithm in dex server#1870abhijith-darshan merged 1 commit intomainfrom
abhijith-darshan merged 1 commit intomainfrom
Conversation
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
uwe-mayer
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a panic in
idproxyintroduced when the binary was built against dex v2.45.1 (#1857).constructDiscovery()determined the signing algorithm solely from the hardcoded
jose.RS256value.constructDiscovery(ctx)still sets
jose.RS256as an initial default but then immediately overwrites it by callings.signer.Algorithm(ctx).server.Config.Signerto be explicitly provided. Since in idxproxymain.gonever set this field,s.signerwasnilat startup, causing an immediate nil pointer dereference panic before the server could serve any requests.signer.LocalConfigbacked by the existing dex storage, so signing keys areread from and rotated in the same postgres
keystable as before — no data migration required.Root Cause
cmd/idproxy/main.gowas not updated alongside the dex v2.45.1 bump in #1857 to satisfy theSignerrequirement inserver.Config.What type of PR is this? (check all applicable)
Added tests?
Added to documentation?
Checklist