Skip to content

docs(plugins): document behavior of PluginOption default values#1872

Merged
IvoGoman merged 2 commits intomainfrom
docs/plugin-defaulting
Mar 31, 2026
Merged

docs(plugins): document behavior of PluginOption default values#1872
IvoGoman merged 2 commits intomainfrom
docs/plugin-defaulting

Conversation

@IvoGoman
Copy link
Copy Markdown
Contributor

Description

PluginOption default values are only applied during admission of a
Plugin. This means during Create/Update. Only PluginPresets will ensure
the Plugin is updated right away. For standalone plugins the reconcile
annotation greenhouse.sap/recocile=some-key should be used.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@IvoGoman IvoGoman requested a review from a team as a code owner March 30, 2026 14:46
@IvoGoman IvoGoman requested a review from Copilot March 30, 2026 14:47
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documentation update clarifying when PluginOption default values are applied and how to get existing Plugins to pick up updated defaults (PluginPreset-managed vs standalone Plugins).

Changes:

  • Clarify that PluginOption defaults are applied during admission on Plugin create/update, and default changes won’t immediately reflect on existing Plugins.
  • Document that PluginPreset-managed Plugins get updated automatically when defaults change, while standalone Plugins require a reconciliation trigger.
  • Convert several docs callouts to > blockquote style for consistent rendering.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
docs/reference/components/plugindefinition.md Adds/clarifies semantics of PluginOption default application and how updates propagate.
docs/reference/components/plugin.md Extends defaulting webhook note to explain PluginPreset vs standalone behavior and reconciliation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/reference/components/plugindefinition.md Outdated
Comment thread docs/reference/components/plugindefinition.md Outdated
Comment thread docs/reference/components/plugin.md
IvoGoman and others added 2 commits March 31, 2026 09:40
PluginOption default values are only applied during admission of a
Plugin. This means during Create/Update. Only PluginPresets will ensure
the Plugin is updated right away. For standalone plugins the reconcile
annotation `greenhouse.sap/recocile=some-key` should be used.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@IvoGoman IvoGoman force-pushed the docs/plugin-defaulting branch from 96c7289 to 6984ac8 Compare March 31, 2026 07:40
@IvoGoman IvoGoman merged commit 4f50c3d into main Mar 31, 2026
8 checks passed
@IvoGoman IvoGoman deleted the docs/plugin-defaulting branch March 31, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants