fix(plugins): expose helm template errors in status

api/v1alpha1/plugin_types.go

@@ -164,6 +164,9 @@ const (
 	// PluginOptionValueInvalidReason is set when option values could not be converted to Helm values
 	PluginOptionValueInvalidReason greenhousemetav1alpha1.ConditionReason = "PluginOptionValueInvalid"
 
+	// PluginHelmTemplateFailedReason is set when templating the Helm chart for the Plugin failed.
+	PluginHelmTemplateFailedReason greenhousemetav1alpha1.ConditionReason = "PluginHelmTemplateFailed"
+
 	// FluxHelmReleaseConfigInvalidReason is set when the generated Flux HelmRelease manifest is invalid and cannot be applied to the cluster.
 	FluxHelmReleaseConfigInvalidReason greenhousemetav1alpha1.ConditionReason = "FluxHelmReleaseConfigInvalid"
 

internal/controller/plugin/plugin_controller_flux.go

@@ -180,6 +180,7 @@ func (r *PluginReconciler) ensureHelmRelease(
 
 		helmRelease, err := helm.TemplateHelmChartFromPluginOptionValues(ctx, r.Client, restClientGetter, &pluginDefinitionSpec, plugin, optionValues)
 		if err != nil {
+			plugin.SetCondition(greenhousemetav1alpha1.FalseCondition(greenhousev1alpha1.HelmReleaseCreatedCondition, greenhousev1alpha1.PluginHelmTemplateFailedReason, err.Error()))
 			return fmt.Errorf("failed to template helm chart for Plugin %s: %w", plugin.Name, err)
 		}