Skip to content

fix(plugindefinitions): provide context for still in use error#1937

Merged
IvoGoman merged 1 commit intomainfrom
fix/plugindefinition-webhook
Apr 22, 2026
Merged

fix(plugindefinitions): provide context for still in use error#1937
IvoGoman merged 1 commit intomainfrom
fix/plugindefinition-webhook

Conversation

@IvoGoman
Copy link
Copy Markdown
Contributor

if a (Cluster-)PluginDefintion is still in use the definition and
one Plugin and the count of other plugins using it will be added
to the error message

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@IvoGoman IvoGoman requested a review from a team as a code owner April 22, 2026 10:28
Comment thread internal/webhook/v1alpha1/plugindefinition_webhook.go Outdated
@IvoGoman IvoGoman force-pushed the fix/plugindefinition-webhook branch 2 times, most recently from 2a0fa77 to bd4072c Compare April 22, 2026 11:38
if a (Cluster-)PluginDefintion is still in use the definition and
one Plugin and the count of other plugins using it will be added
to the error message
@IvoGoman IvoGoman force-pushed the fix/plugindefinition-webhook branch from bd4072c to 14de735 Compare April 22, 2026 11:49
@IvoGoman IvoGoman merged commit b2df05d into main Apr 22, 2026
20 checks passed
@IvoGoman IvoGoman deleted the fix/plugindefinition-webhook branch April 22, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants