Skip to content

fix(ci): remove acknowledge step from e2e runner#2026

Merged
abhijith-darshan merged 1 commit into
mainfrom
fix/e2e-runner-rm-ack
May 25, 2026
Merged

fix(ci): remove acknowledge step from e2e runner#2026
abhijith-darshan merged 1 commit into
mainfrom
fix/e2e-runner-rm-ack

Conversation

@abhijith-darshan
Copy link
Copy Markdown
Contributor

Summary

  • Removes the Acknowledge command step that posted a rocket reaction on /e2e comments
  • The step was consistently failing with 403 due to permission issues on issue_comment-triggered workflows
  • Also removes the now-unused job-level issues: write permission

Test plan

  • Comment /e2e skip on a PR and verify the workflow completes without error

The rocket reaction step was consistently failing with 403 due to
permission issues on issue_comment-triggered workflows. Removing it
to unblock the e2e flow.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Copilot AI review requested due to automatic review settings May 25, 2026 21:13
@abhijith-darshan abhijith-darshan requested a review from a team as a code owner May 25, 2026 21:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ci-e2e-run GitHub Actions workflow to eliminate a failing “acknowledgement” reaction step for /e2e issue comments, addressing consistent 403 permission failures on issue_comment-triggered runs.

Changes:

  • Removed the “Acknowledge command” step that added a rocket reaction to the triggering comment.
  • Removed the job-level issues: write permission that was only needed for the reaction API call (and was causing permission failures).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@abhijith-darshan abhijith-darshan merged commit 4f2f445 into main May 25, 2026
9 checks passed
@abhijith-darshan abhijith-darshan deleted the fix/e2e-runner-rm-ack branch May 25, 2026 22:55
k-fabryczny pushed a commit that referenced this pull request May 29, 2026
The rocket reaction step was consistently failing with 403 due to
permission issues on issue_comment-triggered workflows. Removing it
to unblock the e2e flow.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
k-fabryczny pushed a commit that referenced this pull request May 29, 2026
The rocket reaction step was consistently failing with 403 due to
permission issues on issue_comment-triggered workflows. Removing it
to unblock the e2e flow.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Signed-off-by: Klaudiusz Fabryczny <klaudiusz.fabryczny@sap.com>
k-fabryczny pushed a commit that referenced this pull request May 29, 2026
The rocket reaction step was consistently failing with 403 due to
permission issues on issue_comment-triggered workflows. Removing it
to unblock the e2e flow.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
k-fabryczny pushed a commit that referenced this pull request May 29, 2026
The rocket reaction step was consistently failing with 403 due to
permission issues on issue_comment-triggered workflows. Removing it
to unblock the e2e flow.

Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
Signed-off-by: Klaudiusz Fabryczny <klaudiusz.fabryczny@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants