Merged
Conversation
kanstantsinbuklis-sap
requested review from
MR2011,
copyonwrite,
dorneanu,
drochow and
michalkrzyz
as code owners
3 tasks
michalkrzyz
reviewed
Feb 16, 2026
internal/api/graphql/server.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| depthLimit = 10 |
Collaborator
Author
There was a problem hiding this comment.
Moved to util/config
| dbm.TestTearDown(db) | ||
| }) | ||
|
|
||
| When("request with large depth", func() { |
Collaborator
There was a problem hiding this comment.
'Request with depth exceeding limit' would be more precise
Collaborator
Author
There was a problem hiding this comment.
Renamed
| }) | ||
| }) | ||
|
|
||
| When("request with normal depth", func() { |
Collaborator
There was a problem hiding this comment.
consider 'Request with allowed depth`
Collaborator
Author
There was a problem hiding this comment.
Renamed
| Services model.ServiceConnection `json:"Services"` | ||
| } | ||
|
|
||
| err := util2.RequestWithBackoff(func() error { return client.Run(ctx, req, &respData) }) |
Collaborator
There was a problem hiding this comment.
It would be best to create helper e2e_common.ExecuteGqlQuery which will be extracted from: e2e_common.ExecuteGqlQueryFromFile (and used in here and in e2e_common.ExecuteGqlQueryFromFile)
Collaborator
Author
There was a problem hiding this comment.
Created
kanstantsinbuklis-sap
force-pushed
the
kanstantsinbuklis-sap/issue-1063/add-query-depth-limit
branch
from
a89d552 to
21ac8ff
Compare
kanstantsinbuklis-sap
force-pushed
the
kanstantsinbuklis-sap/issue-1063/add-query-depth-limit
branch
from
21ac8ff to
c9501b7
Compare
michalkrzyz
approved these changes
Feb 16, 2026
michalkrzyz
deleted the
kanstantsinbuklis-sap/issue-1063/add-query-depth-limit
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I've added depth limit for queries to avoid DoS attacks using nested relationships
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Two types of requests occur in the e2e tests:
nilAdded to documentation?