Skip to content

chore(greenhouse): add long SHA to Greenhouse release to fix image scan error and report failing steps#1091

Merged
ArtieReus merged 6 commits intomainfrom
artie-greenhouse-add-long-sha
Jul 18, 2025
Merged

chore(greenhouse): add long SHA to Greenhouse release to fix image scan error and report failing steps#1091
ArtieReus merged 6 commits intomainfrom
artie-greenhouse-add-long-sha

Conversation

@ArtieReus
Copy link
Copy Markdown
Collaborator

@ArtieReus ArtieReus commented Jul 18, 2025

Summary

This PR updates the Greenhouse release configuration to include the full Git SHA (type=raw,value=${{ github.sha }}).
This change addresses a runtime error during image scanning by explicitly including the long SHA, we ensure the image reference is correct and scannable, resolving the scan initialization failure. Adds Slack notification with the name of the failing job for easier debugging.

Changes Made

  • Add long SHA to Greenhouse release
  • Adds Slack notification with the name of the failing job the the release workflow of greenhouse and supernova.

Related Issues

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@ArtieReus ArtieReus requested a review from a team as a code owner July 18, 2025 11:15
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 18, 2025

⚠️ No Changeset found

Latest commit: 9d2bdf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ArtieReus ArtieReus self-assigned this Jul 18, 2025
@ArtieReus ArtieReus added the infrastructure Infrastructure related issues, ci as well label Jul 18, 2025
Comment thread .github/workflows/test.yaml Fixed
Comment thread .github/workflows/test.yaml Fixed
Comment thread .github/workflows/test.yaml Fixed
Comment thread .github/workflows/test.yaml Fixed
Comment thread .github/workflows/test.yaml Fixed
Comment thread .github/workflows/test.yaml Fixed
@ArtieReus ArtieReus changed the title chore(greenhouse): add long SHA to Greenhouse release to fix image scan error chore(greenhouse): add long SHA to Greenhouse release to fix image scan error and report failing steps Jul 18, 2025
Copy link
Copy Markdown
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ArtieReus ArtieReus merged commit b29470e into main Jul 18, 2025
16 checks passed
@ArtieReus ArtieReus deleted the artie-greenhouse-add-long-sha branch July 18, 2025 13:56
andypf pushed a commit that referenced this pull request Jul 29, 2025
…an error and report failing steps (#1091)

* chore(greenhouse): adds long sha as a tag to the release

* chore(ci): test workflow with failing jobs

* chore(ci): adds outcome

* chore(ci): ouput the right var

* chore(ci): extends message with failing jobs

* chore(ci): removes tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Infrastructure related issues, ci as well

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants