chore(kubernetes): add ability to ignore ssl#1108
Merged
Conversation
🦋 Changeset detectedLatest commit: 42447b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
andypf
force-pushed
the
andypf-k8sclient-ssl
branch
from
338dde9 to
6426d47
Compare
andypf
changed the title
hgw77
previously approved these changes
Jul 30, 2025
hodanoori
previously approved these changes
Jul 30, 2025
Contributor
hodanoori
left a comment
hodanoori
left a comment
There was a problem hiding this comment.
I don’t like development and testing to be stopped because certificates are having issues, and I’m always a fan of detailed debug information 😊. I just have a small comment; otherwise, it’s approved from my side.
TilmanHaupt
previously approved these changes
Jul 30, 2025
andypf
dismissed stale reviews from TilmanHaupt, hodanoori, and hgw77
via
5f362a4
TilmanHaupt
approved these changes
Jul 31, 2025
hodanoori
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new options to the client configuration:
debug: Enables debug logging to facilitate troubleshooting and provide more insight into client operations.ignoreSsl: Allows the client to ignore SSL certificate verification errors, such as failures caused by missing or self-signed certificates during the SSL handshake. This helps prevent connection failures in development or testing environments where certificates may not be fully trusted.Changes
debugflag to activate detailed logging output.ignoreSslflag that, when enabled, disables SSL validation to allow connections even if certificates are invalid or missing.ignoreSslflag.Motivation
Security Considerations
ignoreSsloption disables an important security check and should only be used in trusted or non-production environments.