fix(greenhouse): ensure nginx redirects to /index.html for unknown routes#1135
Merged
fix(greenhouse): ensure nginx redirects to /index.html for unknown routes#1135
Conversation
🦋 Changeset detectedLatest commit: 27846fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
andypf
approved these changes
Aug 21, 2025
edda
approved these changes
Aug 21, 2025
hodanoori
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where when(greenhouse is) served via
nginxweb server client side routes like/doop,/heurekado not work because these are unknown to the web server. So in case of unknown routes we need to serve/index.htmlso the client side router takes over the responsibility to render the correct page.Changes Made
nginx.confRelated Issues
https://convergedcloud.slack.com/archives/C04Q0QM40KF/p1755700365206899
Screenshots (if applicable)
N/A
Testing Instructions
Most efficient way is to test it directly on QA after merge otherwise need to spin up nginx on local server with these configuration and verify it that works.
Checklist
PR Manifesto
Review the PR Manifesto for best practises.