Skip to content

fix(greenhouse): ensure nginx redirects to /index.html for unknown routes#1135

Merged
taymoor89 merged 1 commit intomainfrom
taimoor-fix-nginx-conf
Aug 21, 2025
Merged

fix(greenhouse): ensure nginx redirects to /index.html for unknown routes#1135
taymoor89 merged 1 commit intomainfrom
taimoor-fix-nginx-conf

Conversation

@taymoor89
Copy link
Copy Markdown
Contributor

Summary

This PR fixes the issue where when(greenhouse is) served via nginx web server client side routes like /doop, /heureka do not work because these are unknown to the web server. So in case of unknown routes we need to serve /index.html so the client side router takes over the responsibility to render the correct page.

Changes Made

  • Changed nginx.conf

Related Issues

https://convergedcloud.slack.com/archives/C04Q0QM40KF/p1755700365206899

Screenshots (if applicable)

N/A

Testing Instructions

Most efficient way is to test it directly on QA after merge otherwise need to spin up nginx on local server with these configuration and verify it that works.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@taymoor89 taymoor89 marked this pull request as ready for review August 21, 2025 08:47
@taymoor89 taymoor89 requested a review from a team as a code owner August 21, 2025 08:47
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 21, 2025

🦋 Changeset detected

Latest commit: 27846fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@taymoor89 taymoor89 self-assigned this Aug 21, 2025
@taymoor89 taymoor89 added the greenhouse Greenhouse core related task label Aug 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 21, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-08-21 09:13 UTC

@taymoor89 taymoor89 merged commit c2a617e into main Aug 21, 2025
16 checks passed
@taymoor89 taymoor89 deleted the taimoor-fix-nginx-conf branch August 21, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenhouse Greenhouse core related task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants