Skip to content

fix(juno): addressed navigation and initial filters issue#1140

Merged
taymoor89 merged 3 commits intomainfrom
taimoor-fix-issues
Aug 25, 2025
Merged

fix(juno): addressed navigation and initial filters issue#1140
taymoor89 merged 3 commits intomainfrom
taimoor-fix-issues

Conversation

@taymoor89
Copy link
Copy Markdown
Contributor

@taymoor89 taymoor89 commented Aug 22, 2025

Summary

This PR fixes broken navigation from any other app to supernova app as well as combines initial filters with filters from the url state.

Changes Made

  • Combined initial filters with URL filters on /alerts page.
  • When navigating to other app the state of the previous app is no longer copied.
  • Sanitized NaN returned by the old state for some of the url state values.

Screenshots (if applicable)

Initial filters are applied

Screenshot 2025-08-22 at 19 19 08

Navigation fixed

2025-08-22_19-20-38.mp4

Testing Instructions

The fix can only be tested on local environment because in PR preview for demo user there are no initial filters defined on appProps.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 22, 2025

🦋 Changeset detected

Latest commit: 8a49a56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudoperators/juno-app-greenhouse Patch
@cloudoperators/juno-app-supernova Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 22, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-08-25 07:43 UTC

@taymoor89 taymoor89 changed the title fix(juno): address navigation and initial filters issue fix(juno): addressed navigation and initial filters issue Aug 22, 2025
@taymoor89 taymoor89 marked this pull request as ready for review August 22, 2025 14:28
@taymoor89 taymoor89 requested a review from a team as a code owner August 22, 2025 14:28
@taymoor89 taymoor89 self-assigned this Aug 22, 2025
@taymoor89 taymoor89 added the app Any app that is not specific label that lives under apps/ label Aug 22, 2025
@taymoor89 taymoor89 merged commit 9e9669f into main Aug 25, 2025
21 checks passed
@taymoor89 taymoor89 deleted the taimoor-fix-issues branch August 25, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app Any app that is not specific label that lives under apps/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants