fix(kubernetes): fix HTTPS module bundling issues in production#1141
Merged
fix(kubernetes): fix HTTPS module bundling issues in production#1141
Conversation
|
ArtieReus
reviewed
Aug 26, 2025
edda
approved these changes
Aug 26, 2025
hgw77
approved these changes
Aug 27, 2025
Contributor
hgw77
left a comment
There was a problem hiding this comment.
to disable ssl verify in development is fine for me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Applications using this client were throwing errors in production environments due to the
httpsmodule being incorrectly processed during the bundling process. This caused runtime failures when consuming applications tried to create HTTPS agents for SSL certificate handling.Error symptoms:
https.Agent is not a constructorerrors in production for consuming applicationsignoreSsl: trueRoot Cause
The
httpsmodule (Node.js built-in) was being processed by the bundler instead of being treated as an external dependency. This caused issues because:httpsmodule incorrectlyhttpsmodule functionality when using the bundled clientSolution
Added
https(and other Node.js built-ins) to theexternalconfiguration invite.config.ts:Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.