Skip to content

feat(ui): fix state bug in ToggleButton#1180

Merged
guoda-puidokaite merged 6 commits intomainfrom
guoda-toggle-button-2
Sep 26, 2025
Merged

feat(ui): fix state bug in ToggleButton#1180
guoda-puidokaite merged 6 commits intomainfrom
guoda-toggle-button-2

Conversation

@guoda-puidokaite
Copy link
Copy Markdown
Contributor

Summary

Changes Made

  • Fulfilled all ACs.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

Testing

Reviewers: Please see Quality Assurance section in the main ticket. 🙏

PR Manifesto

Review the PR Manifesto for best practises.

@guoda-puidokaite guoda-puidokaite self-assigned this Sep 26, 2025
@guoda-puidokaite guoda-puidokaite requested review from a team and franzheidl as code owners September 26, 2025 10:20
@guoda-puidokaite guoda-puidokaite added package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library labels Sep 26, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 26, 2025

🦋 Changeset detected

Latest commit: 43bf4bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@cloudoperators/juno-ui-components Minor
@cloudoperators/juno-app-carbon Patch
@cloudoperators/juno-app-doop Patch
@cloudoperators/juno-app-example Patch
@cloudoperators/juno-app-greenhouse Patch
@cloudoperators/juno-app-heureka Patch
@cloudoperators/juno-app-supernova Patch
@cloudoperators/juno-app-template Patch
@cloudoperators/juno-messages-provider Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@guoda-puidokaite guoda-puidokaite changed the title feat(ui): fix bug ToggleButton and SortButton components feat(ui): fix state bug in ToggleButton Sep 26, 2025
@guoda-puidokaite guoda-puidokaite linked an issue Sep 26, 2025 that may be closed by this pull request
4 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 26, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-26 14:02 UTC

taymoor89
taymoor89 previously approved these changes Sep 26, 2025
Copy link
Copy Markdown
Contributor

@taymoor89 taymoor89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it...

andypf
andypf previously approved these changes Sep 26, 2025
@guoda-puidokaite guoda-puidokaite dismissed stale reviews from andypf and taymoor89 via 176141e September 26, 2025 13:11
andypf
andypf previously approved these changes Sep 26, 2025
@guoda-puidokaite guoda-puidokaite merged commit 900b0be into main Sep 26, 2025
16 checks passed
@guoda-puidokaite guoda-puidokaite deleted the guoda-toggle-button-2 branch September 26, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task](ui): create ToggleButton component

3 participants