Skip to content

chore(heureka): enable no-unused-vars rule#1204

Merged
taymoor89 merged 1 commit intomainfrom
1115-fix-eslint
Oct 10, 2025
Merged

chore(heureka): enable no-unused-vars rule#1204
taymoor89 merged 1 commit intomainfrom
1115-fix-eslint

Conversation

@taymoor89
Copy link
Copy Markdown
Contributor

Summary

This PR enables @typescript-eslint/no-unused-vars eslint rule which will not allow us to leave unused variables/imports that are not intentional.

Changes Made

  • Enabled @typescript-eslint/no-unused-vars rule
  • Ignored routeTree.gen.ts file
  • Ignored this rule for the lines where the intention is clear about why we're doing it.

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. pnpm i
  2. pnpm TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@taymoor89 taymoor89 requested a review from a team as a code owner October 9, 2025 14:45
@taymoor89 taymoor89 self-assigned this Oct 9, 2025
@taymoor89 taymoor89 force-pushed the 1115-fix-eslint branch 2 times, most recently from 512fc4b to b66fb4b Compare October 9, 2025 15:23
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 9, 2025

⚠️ No Changeset found

Latest commit: b66fb4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-10 14:13 UTC

Copy link
Copy Markdown
Contributor

@TilmanHaupt TilmanHaupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread apps/heureka/eslint.config.mjs
Copy link
Copy Markdown
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taymoor89 taymoor89 merged commit b1e5a52 into main Oct 10, 2025
16 checks passed
@taymoor89 taymoor89 deleted the 1115-fix-eslint branch October 10, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants