Skip to content

chore(juno): update tanstack router to fix basepath and schema validation issues#1246

Merged
taymoor89 merged 5 commits intomainfrom
1244-fix-old-state-conversion
Oct 23, 2025
Merged

chore(juno): update tanstack router to fix basepath and schema validation issues#1246
taymoor89 merged 5 commits intomainfrom
1244-fix-old-state-conversion

Conversation

@taymoor89
Copy link
Copy Markdown
Contributor

@taymoor89 taymoor89 commented Oct 23, 2025

Summary

Updates tanstack router in order to fix basepath overwrite issue when redirecting. It also fixes the issue where schema validation of /alerts page was broken for falsy values because now they are all treated as optional.

Changes Made

  • Removed manual normalization of part of legacy state to undefined as it is no longer needed with latest version of tanstack router.
  • Changed the way how we redirect to default page based on an official example.

Related Issues

#1244

  • Issue 1: [link to issue]

Screenshots (if applicable)

Testing Instructions

  1. pnpm i
  2. pnpm TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@taymoor89 taymoor89 requested a review from a team as a code owner October 23, 2025 09:56
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 23, 2025

🦋 Changeset detected

Latest commit: 9bcbbc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cloudoperators/juno-app-supernova Patch
@cloudoperators/juno-app-greenhouse Patch
@cloudoperators/juno-app-heureka Patch
@cloudoperators/juno-app-doop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 23, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-23 11:48 UTC

ArtieReus
ArtieReus previously approved these changes Oct 23, 2025
Copy link
Copy Markdown
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taymoor89 taymoor89 merged commit 5931aab into main Oct 23, 2025
16 checks passed
@taymoor89 taymoor89 deleted the 1244-fix-old-state-conversion branch October 23, 2025 11:48
taymoor89 added a commit that referenced this pull request Oct 28, 2025
…tion issues (#1246)

* fix(greenhouse): convert null to undefined

* chore(juno): change how we redirect to default page

* chore(supernova): remove manual normalization of legacy state

* chore(juno): update changesets

* test(supernova): remove test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants