Skip to content

feat(ui): create SignInForm component#1450

Merged
vlad-schur-external-sap merged 9 commits intomainfrom
vlad-sign-in-form-component
Feb 13, 2026
Merged

feat(ui): create SignInForm component#1450
vlad-schur-external-sap merged 9 commits intomainfrom
vlad-sign-in-form-component

Conversation

@vlad-schur-external-sap
Copy link
Copy Markdown
Contributor

@vlad-schur-external-sap vlad-schur-external-sap commented Feb 11, 2026

Summary

Created a SignInForm component that can be used to render consistent, configurable Sign In forms according to the visual design in Figma.

Changes Made

  • Added SignInForm Component
  • Added corresponding stories to the component with the most used customer scenarios
  • Added tests

Related Issues

Screenshots (if applicable)

SignInForm component documentation
Screenshot 2026-02-12 at 11 09 12
SignInForm stories
Screenshot 2026-02-12 at 11 09 22

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 11, 2026

🦋 Changeset detected

Latest commit: 830c110

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@cloudoperators/juno-ui-components Minor
@cloudoperators/juno-app-carbon Patch
@cloudoperators/juno-app-doop Patch
@cloudoperators/juno-app-example Patch
@cloudoperators/juno-app-greenhouse Patch
@cloudoperators/juno-app-heureka Patch
@cloudoperators/juno-app-supernova Patch
@cloudoperators/juno-app-template Patch
@cloudoperators/juno-messages-provider Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vlad-schur-external-sap vlad-schur-external-sap marked this pull request as draft February 11, 2026 09:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 11, 2026

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-02-13 14:22 UTC

@franzheidl
Copy link
Copy Markdown
Member

franzheidl commented Feb 12, 2026

Hey @vlad-schur-external-sap ,

thanks so much! Here's a couple of things:

  1. Thought about the story with only one button (external auth), I think we should remove it. The decision whether to render a form or just the button is not a concern of the SigninForm itself, but of the surrounding page/app.
    This case will be reflected when we build the templates in a later task.
  2. Please change the PR title to something that fits our requirements, so the PR can actually pass our checks and can be merged, e.g. "feat(ui): add SignInForm component".
  3. Please add a changeset.
  4. Un-draft the PR so it can be reviewed and merged.
  5. Write a quick summary, one-liner is fine in this case IMO.

Any questions, hit me up.

@franzheidl franzheidl added the ui-components All tasks related to juno-ui-components library label Feb 12, 2026
@franzheidl franzheidl linked an issue Feb 12, 2026 that may be closed by this pull request
3 tasks
@vlad-schur-external-sap vlad-schur-external-sap changed the title sign in form component feat(ui): create SignInForm component Feb 12, 2026
@vlad-schur-external-sap vlad-schur-external-sap marked this pull request as ready for review February 12, 2026 10:02
@franzheidl
Copy link
Copy Markdown
Member

Ah sorry, my bad, PortalProvider may be needed for Select, I wasn't thinking. 😓

franzheidl
franzheidl previously approved these changes Feb 13, 2026
Copy link
Copy Markdown
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! I like it very much. Just added some comments to discuss...

Comment thread packages/ui-components/src/components/SignInForm/SignInForm.component.tsx Outdated
Comment thread packages/ui-components/src/components/SignInForm/SignInForm.component.tsx Outdated
Comment thread packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx Outdated
Copy link
Copy Markdown
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything ok from my side :)

Copy link
Copy Markdown
Contributor

@edda edda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚀

@vlad-schur-external-sap vlad-schur-external-sap merged commit ce5ee1f into main Feb 13, 2026
17 checks passed
@vlad-schur-external-sap vlad-schur-external-sap deleted the vlad-sign-in-form-component branch February 13, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui-components All tasks related to juno-ui-components library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task](ui): create SignInForm component

4 participants