Skip to content

chore(greenhouse): use page level error message instead of inline#1481

Merged
taymoor89 merged 1 commit intomainfrom
1480-enhance-error-message
Feb 25, 2026
Merged

chore(greenhouse): use page level error message instead of inline#1481
taymoor89 merged 1 commit intomainfrom
1480-enhance-error-message

Conversation

@taymoor89
Copy link
Copy Markdown
Contributor

Summary

This PR removes inline ErrorMessage from ReconcileButton and rather uses addMessage api and MessagesProvider to render the page level error.

Changes Made

  • Removed ErrorMessage from ReconcileButton
  • Added MessagesProvider to the admin layout.

Related Issues

Screenshots (if applicable)

Before:

Screenshot 2026-02-25 at 10 58 48

After:

Screenshot 2026-02-25 at 10 25 52

Testing Instructions

  1. pnpm i
  2. pnpm TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@taymoor89 taymoor89 self-assigned this Feb 25, 2026
@taymoor89 taymoor89 requested a review from a team as a code owner February 25, 2026 10:00
@taymoor89 taymoor89 added the greenhouse Greenhouse core related task label Feb 25, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 25, 2026

🦋 Changeset detected

Latest commit: 96b3fc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@taymoor89 taymoor89 force-pushed the 1480-enhance-error-message branch from fcaad83 to 96b3fc2 Compare February 25, 2026 10:01
@taymoor89 taymoor89 linked an issue Feb 25, 2026 that may be closed by this pull request
3 tasks
@taymoor89 taymoor89 merged commit d98d06a into main Feb 25, 2026
15 checks passed
@taymoor89 taymoor89 deleted the 1480-enhance-error-message branch February 25, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenhouse Greenhouse core related task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task](greenhouse): use MessagesProvider to display page level errors

3 participants