feat(ui): allow button type to overwritten#1541
Merged
vlad-schur-external-sap merged 7 commits intomainfrom Mar 16, 2026
Merged
feat(ui): allow button type to overwritten#1541vlad-schur-external-sap merged 7 commits intomainfrom
vlad-schur-external-sap merged 7 commits intomainfrom
Conversation
vlad-schur-external-sap
requested review from
a team and
franzheidl
as code owners
🦋 Changeset detectedLatest commit: 50b889b The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
vlad-schur-external-sap
added
the
ui-components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
<Button type />to be overridden, provides flexibility for different use cases (e.g., using"submit","reset", or"button"). It prevents unintended form submissions or lets developers control behavior without manually wrapping or replacing the component.Changes Made
ButtonandAppShell).Related Issues
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.