chore(apps): remove unused variables, imports, functions and classes#1554
chore(apps): remove unused variables, imports, functions and classes#1554
Conversation
🦋 Changeset detectedLatest commit: bc88458 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
guoda-puidokaite
left a comment
There was a problem hiding this comment.
Thank You for the fixes!
(Suggestion)
As discussed... For future improvement, in this or another PR we should update the lint check to fail on unused vars, as in ui-components. Should be a matter of comparing config files.
I created a test PR with unused vars in doop and ui-components to show that:
doop(and other apps) still passes in this caseui-componentscatches unused vars and fails the pipeline
agree. Lets improve the lint checker. |
guoda-puidokaite
left a comment
There was a problem hiding this comment.
Thank You! Can improve anytime.
Summary
Removes unused variables, imports, functions, and classes identified by static code analysis to improve code quality and maintainability.
Changes
updateSecretshelper function that was never calledFiles Changed
apps/supernova/src/App.tsx- removed unusedisObjectWithKeysimportapps/supernova/src/components/StoreProvider.tsx- removed unuseddevtoolsimportapps/doop/src/App.tsx- removed unusedContentHeadingimportapps/doop/src/routes/violations.tsx- removed unusedretainSearchParamsimportapps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/PluginEdit.tsx- removed unused variables andonPanelClosefunctionapps/greenhouse/src/components/core-apps/org-admin/components/secrets/store.ts- removed unusedupdateSecretsfunctionTesting Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.