Skip to content

fix(greenhouse): improve ReadinessConditions layout with responsive column widths#1694

Merged
ArtieReus merged 7 commits into
mainfrom
artie-fix-readiness-boxes
May 18, 2026
Merged

fix(greenhouse): improve ReadinessConditions layout with responsive column widths#1694
ArtieReus merged 7 commits into
mainfrom
artie-fix-readiness-boxes

Conversation

@ArtieReus
Copy link
Copy Markdown
Collaborator

@ArtieReus ArtieReus commented May 13, 2026

Summary

Fixes text overflow issues in the ReadinessConditions component where long condition type names (e.g., "HelmReleaseCreated") were overlapping with their corresponding values.

Changes Made

  • Added responsive column width classes to left column (labels) in condition cards with breakpoints for mobile, tablet, desktop, and extra-large screens
  • Set max-w-xs (320px) on label column to prevent excessive width on very large screens
  • Configured word-wrapping to only occur on very small screens (< 640px) using whitespace-normal sm:whitespace-nowrap
  • Simplified component structure by removing unnecessary Stack wrapper around Grid
  • Extracted common grid column classes to a constant for consistency and maintainability
  • Added mt-4 margin to Grid for proper spacing from badge

Related Issues

Fixes visual layout bug where condition type labels overlapped with their values in admin condition cards.

Screenshots (if applicable)

Before:

Screen.Recording.2026-05-13.at.19.09.25.mov

After:

Screen.Recording.2026-05-13.at.19.08.41.mov

Testing Instructions

  1. pnpm i
  2. pnpm dev (or start the greenhouse app)
  3. Navigate to an admin view that displays ReadinessConditions with enableDetailsView={true}
  4. Click "Show full conditions details"
  5. Verify that condition type labels (especially long ones like "HelmReleaseCreated") don't overlap with their values
  6. Test responsive behavior by resizing the browser window to mobile, tablet, and desktop sizes

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

ArtieReus added 2 commits May 13, 2026 19:01
…olumn widths

Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@ArtieReus ArtieReus self-assigned this May 13, 2026
Copilot AI review requested due to automatic review settings May 13, 2026 17:12
@ArtieReus ArtieReus requested a review from a team as a code owner May 13, 2026 17:12
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

🦋 Changeset detected

Latest commit: 334350c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Greenhouse admin ReadinessConditions details layout to prevent long condition type labels from overlapping their values by introducing responsive label-column sizing and simplifying the card structure.

Changes:

  • Added responsive width/overflow/wrapping Tailwind classes for the label column via a shared gridColumnClasses constant.
  • Simplified ConditionCard layout by removing an extra Stack wrapper and adding mt-4 spacing to the Grid.
  • Added a changeset to publish the Greenhouse app patch.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/greenhouse/src/components/admin/common/ReadinessConditions.tsx Adjusts the expanded condition-card grid layout to avoid label/value overlap using responsive column sizing.
.changeset/fruity-schools-stand.md Declares a patch release for the Greenhouse app reflecting the UI fix.

Comment thread apps/greenhouse/src/components/admin/common/ReadinessConditions.tsx
ArtieReus added 2 commits May 14, 2026 11:55
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@ArtieReus ArtieReus linked an issue May 14, 2026 that may be closed by this pull request
TilmanHaupt
TilmanHaupt previously approved these changes May 15, 2026
Comment thread apps/greenhouse/src/components/admin/common/ReadinessConditions.tsx Outdated
Comment thread apps/greenhouse/src/components/admin/common/ReadinessConditions.tsx Outdated
@MartinS-git MartinS-git requested a review from TilmanHaupt May 15, 2026 12:57
Co-authored-by: Martin Schulze <info@eyepic.de>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@ArtieReus ArtieReus force-pushed the artie-fix-readiness-boxes branch from 48c3f28 to 108a949 Compare May 18, 2026 08:45
@ArtieReus ArtieReus merged commit c828ab1 into main May 18, 2026
22 checks passed
@ArtieReus ArtieReus deleted the artie-fix-readiness-boxes branch May 18, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug](greenhouse): Condition name not wrapped when Browser resized

4 participants