fix(greenhouse): upgrade Vitest to 4.1.6#1697
Conversation
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
|
|
You've hit your rate limit. Please wait for your limit to reset in 1 hour 50 minutes or switch to auto model to continue. 🤦 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 46 out of 47 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/k8s-client/test/client.test.ts:66
vi.stubGlobal('fetch', ...)is not reverted byvi.restoreAllMocks(). Without an explicit cleanup (e.g.vi.unstubAllGlobals()/ restoring the priorfetch), the stubbedfetchcan leak into other tests in the same worker.
beforeEach(() => {
vi.clearAllMocks()
// Set up default successful response
mockFetch.mockResolvedValue(createMockResponse({ success: true }))
vi.stubGlobal("fetch", mockFetch)
})
afterEach(() => {
vi.restoreAllMocks()
})
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Summary
This PR fixes the text overlap issue in the ReadinessConditions component where long condition names were overlapping with their values. Additionally, it upgrades Vitest from 3.2.4 to 4.1.6 across the entire monorepo, following the official migration guide.
Changes Made
UI Fixes
w-2/5 md:w-1/3 lg:w-1/5 xl:w-1/6with proper text wrappingVitest 4.1.6 Migration
vitest.setup.tsfiles to use@testing-library/jest-dom/vitestimport patternglobal.windowandglobal.documentassignments (jsdom provides these automatically)global.fetchassignments to usevi.stubGlobal('fetch', mockFetch)pattern"lib": ["ES2017", "DOM"]for Object.values() and browser API support"types": ["vitest/globals", "node"]for proper Node.js type supportnode:testtovitest)MockInstancetype for Vitest 4 compatibilityRelated Issues
Testing Instructions
pnpm ipnpm lint- Verify all lint checks passpnpm typecheck- Verify all TypeScript checks passpnpm test- Verify all tests pass with Vitest 4.1.6Checklist
PR Manifesto
Review the PR Manifesto for best practises.