Skip to content

MC-15617: add docs#423

Merged
dpmurray21 merged 2 commits intocmc-devfrom
feature/MC-15617-add-custom-rule
Aug 26, 2021
Merged

MC-15617: add docs#423
dpmurray21 merged 2 commits intocmc-devfrom
feature/MC-15617-add-custom-rule

Conversation

@dpmurray21
Copy link
Copy Markdown

Fixes MC-15617

Copy link
Copy Markdown

@razine-bensari razine-bensari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good senior 🇲🇽

Copy link
Copy Markdown

@m-orfanos m-orfanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, LGTM!

##### Create a WAF rule based on a request made to an existing site

```
GET "https://cloudmc_endpoint/api/v1/services/{serviceCode}/{environment}/wafrequests/{wafrequestId}?operation=create_rule&siteId={siteId}"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POST?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good catch, fixing now

@dpmurray21 dpmurray21 merged commit ed232a7 into cmc-dev Aug 26, 2021
@dpmurray21 dpmurray21 deleted the feature/MC-15617-add-custom-rule branch August 26, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants