Overall refactor of Custom Resources #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khos2ow
changed the title
khos2ow
force-pushed
the
remove-providers
branch
from
fb8cfbd to
bf3c2bd
Compare
khos2ow
changed the title
Contributor
|
why should we delete the library section ? |
pdion891
approved these changes
Dec 28, 2018
Contributor
Author
|
@pdion891 because this way of custom resource definition has been deprecated on Chef 13+, the same way we deprecated mysql part of cookbook. |
khos2ow
force-pushed
the
remove-providers
branch
from
1730b80 to
fa0a085
Compare
khos2ow
force-pushed
the
remove-providers
branch
from
fa0a085 to
fb331e4
Compare
khos2ow
force-pushed
the
remove-providers
branch
from
6ec1fc1 to
9abf6d6
Compare
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an overall refactor of Custom Resources, it removes deprecated
providersand move them into correspondingresources/files.Also fixes all the Cookstyle, Foodcritic and Serverspec issues.