Added install scripts #15

goruha · 2018-06-11T17:57:25Z

What

Added shell script to install tf-state module
Added shell script to install root-iam module

Why

To simplify installation of tf-state
To simplify installation of root-iam

aknysh · 2018-06-11T18:08:30Z

aws/tfstate-backend/install.sh

@@ -0,0 +1,23 @@
+#!/usr/bin/env bash
+
+sed -i "s/backend/#backend/" main.tf


this will change backend in two other places:
https://github.com/cloudposse/terraform-root-modules/blob/master/aws/tfstate-backend/main.tf#L54
https://github.com/cloudposse/terraform-root-modules/blob/master/aws/tfstate-backend/main.tf#L55

I did this before:

sed -i 's/backend "s3" {}/#backend "s3" {}/' main.tf sed -i 's/#backend "s3" {}/backend "s3" {}/' main.tf```

but it's too fragile and could be broken if the file changes
We need to think of a better way.

aknysh · 2018-06-11T18:09:56Z

aws/tfstate-backend/install.sh

+echo "yes" | init-terraform
+
+
+echo "Add to the Geodesic Module Dockerfile following"


Add to the Geodesic Module Dockerfile the following ENV vars:

aknysh

looks good, a few comments

osterman · 2018-06-13T00:53:51Z

aws/tfstate-backend/install.sh

+
+## Spaces before and after `backend` required to select right word, because `backend` appears 3 times in main.tf
+sed -i "s/ backend / #backend /" main.tf
+sed -i "s/ role_arn / #role_arn /" main.tf


This can't be generally true. This is maybe true for the "root" org, but certainly not on subaccounts.

roles are how we determine the account in which to provision the resources, so if this is not set, terraform won't use the appropriate account.

I think this will need to be an arg. e.g. --disable-role-arn

yes, we disable the role only in the root account and only once at cold start when we provision iam and we don't have any roles yet

So the way I typically do something like this, is:
have two different make targets with
two different "invisible-to-terraform™" versions of the resource definitions:

provider-with-assume-role.tf.in

provider-bootstrap.tf.in

and the make targets look like:

bootstrap: rm -f provider.tf ln -s provider-bootstrap.tf.in provider.tf default: rm -f provider.tf ln -s provider-with-assume-role.tf.in provider.tf

and the install script then looks closer to:

init-terraform make bootstrap terraform plan -input=false -out=install-plan && terraform apply -input=false install-plan && mv -v install-plan install-plan.applied

osterman · 2018-06-13T01:04:11Z

aws/tfstate-backend/install.sh

+init-terraform
+terraform plan
+
+export TF_BUCKET=$(echo "yes" | terraform apply | grep -o -e "tfstate_backend_s3_bucket_id\s=\s.*" | cut -d ' ' -f 3)


Clever, but use terraform output instead.

export TF_BUCKET=$(terraform output -json | jq -r .tfstate_backend_s3_bucket_id.value)

osterman · 2018-06-13T01:05:06Z

aws/tfstate-backend/install.sh

+echo "Add to the Geodesic Module Dockerfile following"
+echo "#----------------------------------------------"
+echo "ENV TF_BUCKET=\"${TF_BUCKET}\""
+echo "ENV TF_BUCKET_REGION=\"${TF_BUCKET_REGION}\""


Output lock table too:

terraform output -json | jq -r .tfstate_backend_dynamodb_table_id.value

osterman · 2018-06-13T01:05:34Z

aws/tfstate-backend/install.sh

+
+sed -i "s/ #role_arn / role_arn /" main.tf
+
+echo "Add to the Geodesic Module Dockerfile following"


Add the following to the Geodesic Module's Dockerfile:

osterman · 2018-06-13T01:12:54Z

aws/tfstate-backend/install.sh

+#!/usr/bin/env bash
+
+## Spaces before and after `backend` required to select right word, because `backend` appears 3 times in main.tf
+sed -i "s/ backend / #backend /" main.tf


Let's be more precise.

sed -Ei 's/^(\s+backend\s+)/#\1/' main.tf

osterman · 2018-06-13T01:14:08Z

aws/tfstate-backend/install.sh

+export TF_BUCKET_REGION=${TF_VAR_region}
+
+## Spaces before and after `backend` required to select right word, because `backend` appears 3 times in main.tf
+sed -i "s/ #backend / backend /" main.tf


Use regex style from above.

osterman · 2018-06-13T01:14:16Z

aws/tfstate-backend/install.sh

+
+echo "yes" | init-terraform
+
+sed -i "s/ #role_arn / role_arn /" main.tf


Use regex style from above

osterman · 2018-06-13T01:15:09Z

aws/tfstate-backend/install.sh

+echo "ENV TF_BUCKET=\"${TF_BUCKET}\""
+echo "ENV TF_BUCKET_REGION=\"${TF_BUCKET_REGION}\""
+echo "#----------------------------------------------"
+echo "And rebuild the module"


Then rebuild the geodesic module.

osterman · 2018-06-13T01:16:21Z

aws/tfstate-backend/install.sh

+
+init-terraform
+terraform plan
+


Run terraform apply here.

osterman · 2018-06-15T18:33:46Z

aws/accounts/install.sh

+#!/usr/bin/env bash
+
+## Spaces before and after `backend` required to select right word, because `backend` appears 3 times in main.tf
+sed -i "s/ role_arn / #role_arn /" main.tf


See previous PR comments. This was not updated.

osterman · 2018-06-15T18:34:21Z

aws/cloudtrail/install.sh

@@ -0,0 +1,12 @@
+#!/usr/bin/env bash


I don't want this script duplicated into each project. If we need that, then move it to geodesic

tamsky · 2018-06-16T06:45:30Z

aws/accounts/install.sh

+sed -i "s/ role_arn / #role_arn /" main.tf
+
+init-terraform
+terraform plan


suggest perhaps:

init-terraform terraform plan -input=false -out=install-plan && terraform apply -input=false install-plan && mv install-plan install-plan.applied

tamsky · 2018-06-16T06:51:32Z

aws/tfstate-backend/install.sh

+
+## Spaces before and after `backend` required to select right word, because `backend` appears 3 times in main.tf
+sed -i "s/ backend / #backend /" main.tf
+sed -i "s/ role_arn / #role_arn /" main.tf


So the way I typically do something like this, is:
have two different make targets with
two different "invisible-to-terraform™" versions of the resource definitions:

provider-with-assume-role.tf.in

provider-bootstrap.tf.in

and the make targets look like:

bootstrap: rm -f provider.tf ln -s provider-bootstrap.tf.in provider.tf default: rm -f provider.tf ln -s provider-with-assume-role.tf.in provider.tf

and the install script then looks closer to:

init-terraform make bootstrap terraform plan -input=false -out=install-plan && terraform apply -input=false install-plan && mv -v install-plan install-plan.applied

* master: Separate `iam` into `root-iam` and `iam` (#18) fix usage syntax of data.aws_availability_zones... (#16)

osterman · 2018-06-26T14:08:21Z

Fix PR name

comments addressed

Added install ts-state script

065ed84

goruha requested a review from osterman June 11, 2018 17:57

goruha assigned osterman Jun 11, 2018

aknysh reviewed Jun 11, 2018

View reviewed changes

aknysh previously requested changes Jun 11, 2018

View reviewed changes

goruha added 4 commits June 12, 2018 18:14

Address PR comments

607199e

Added install script

987202a

Comment assme role arn

dea35be

Address PRs

4210eb3

osterman reviewed Jun 13, 2018

View reviewed changes

aws/tfstate-backend/install.sh

init-terraform

terraform plan

Copy link

Member

osterman Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run terraform apply here.

goruha added 4 commits June 13, 2018 16:07

Added terraform provision

98da1ff

Added branch labels for docker

7ccc809

Rollback image tags

6e73729

Rollback image tags

03b7c4d

osterman reviewed Jun 15, 2018

View reviewed changes

osterman mentioned this pull request Jun 15, 2018

Document reference-architectures cloudposse/docs#139

Merged

tamsky reviewed Jun 16, 2018

View reviewed changes

goruha added 3 commits June 23, 2018 20:20

Merge branch 'master' into feature-add-install-tf-state

2a4abd1

* master: Separate `iam` into `root-iam` and `iam` (#18) fix usage syntax of data.aws_availability_zones... (#16)

Fix roles

4874b2a

Address comments

92bfaa3

goruha changed the title ~~Added install ts-state script~~ Added install scripts Jun 26, 2018

Address PR comments

931b2b1

osterman approved these changes Jul 2, 2018

View reviewed changes

goruha merged commit 3f2ec13 into master Jul 2, 2018

goruha deleted the feature-add-install-tf-state branch July 2, 2018 17:15

		@@ -0,0 +1,23 @@
		#!/usr/bin/env bash

		sed -i "s/backend/#backend/" main.tf

		echo "yes" \| init-terraform


		echo "Add to the Geodesic Module Dockerfile following"


		sed -i "s/ #role_arn / role_arn /" main.tf

		echo "Add to the Geodesic Module Dockerfile following"

Uh oh!

Added install scripts #15

Added install scripts #15

Uh oh!

Conversation

goruha commented Jun 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aknysh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

osterman Jun 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

osterman commented Jun 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

goruha commented Jun 11, 2018 •

edited

Loading

osterman Jun 13, 2018 •

edited

Loading