Migrate to README.yaml format, add travis #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Jun 26, 2018
|
|
||
| # Short description of this project | ||
| description: |- | ||
| This is a collection of reusable root modules for CloudPosse AWS accounts. |
osterman
changed the title
vadim-gleif
force-pushed
the
refactor-readme
branch
from
f03cfcc to
b2ec5dc
Compare
Member
|
Need to fix image sizes. Use the github avatar url.
|
Member
|
Avatars are still broken https://github.com/cloudposse/terraform-root-modules/blob/refactor-readme/README.md#contributors |
osterman
reviewed
Jul 2, 2018
README.yaml
Outdated
| - name: "Erik Osterman" | ||
| homepage: "https://github.com/osterman" | ||
| avatar: "http://s.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb?s=144" | ||
| avatar: "http://s.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb?s=150" |
osterman
reviewed
Jul 2, 2018
README.yaml
Outdated
| - name: "Andriy Knysh" | ||
| homepage: "https://github.com/aknysh" | ||
| avatar: "https://avatars0.githubusercontent.com/u/7356997?v=4&u=ed9ce1c9151d552d985bdf5546772e14ef7ab617&s=144" | ||
| avatar: "https://avatars0.githubusercontent.com/u/7356997?v=4&u=ed9ce1c9151d552d985bdf5546772e14ef7ab617&s=150" |
osterman
reviewed
Jul 2, 2018
README.yaml
Outdated
| - name: "Marc Tamsky" | ||
| homepage: "https://github.com/tamsky" | ||
| avatar: "https://avatars1.githubusercontent.com/u/96978?s=460&v=4" | ||
| avatar: "https://avatars1.githubusercontent.com/u/96978?s=150&v=4" |
osterman
reviewed
Jul 4, 2018
README.yaml
Outdated
| contributors: | ||
| - name: "Erik Osterman" | ||
| homepage: "https://github.com/osterman" | ||
| avatar: "https://github.com/osterman.png?size=150" |
Member
There was a problem hiding this comment.
Let's remove homepage and avatar since those can be derived automatically.
osterman
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
README.yamlwhy
todo
relatedsection