Added ecr #20
Merged
Added ecr #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Jun 28, 2018
aws/ecr/ecr-repo-app.tf
Outdated
| source = "git::https://github.com/cloudposse/terraform-aws-kops-ecr.git?ref=tags/0.1.0" | ||
| namespace = "${var.namespace}" | ||
| stage = "${var.stage}" | ||
| name = "langing" |
Member
There was a problem hiding this comment.
make it a variable. Add terraform.tfvars.example with defaults.
sarkis
previously approved these changes
Jun 29, 2018
osterman
reviewed
Jun 29, 2018
aws/ecr/ecr-repo-app.tf
Outdated
| source = "git::https://github.com/cloudposse/terraform-aws-kops-ecr.git?ref=tags/0.1.0" | ||
| namespace = "${var.namespace}" | ||
| stage = "${var.stage}" | ||
| name = "${element(repositories_names,0)}" |
Member
There was a problem hiding this comment.
This is an invalid variable :P
Member
There was a problem hiding this comment.
Also, I don't understand why it's valid that we create an ECR for only the first (0) repository.
osterman
reviewed
Jun 29, 2018
aws/ecr/main.tf
Outdated
| } | ||
|
|
||
| variable "repositories_names" { | ||
| type = "list" |
Member
There was a problem hiding this comment.
Seems like this should be a string or our ecr module should be made to support lists.
osterman
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why