Added rds as backing service #43
Conversation
aws/backing-services/rds.tf
Outdated
| variable "RDS_SNAPSHOT" { | ||
| type = "string" | ||
| default = "" | ||
| description = "Restore snapshots" |
There was a problem hiding this comment.
Set to a snapshot ID to restore from snapshot
aws/backing-services/rds.tf
Outdated
| variable "RDS_PARAMETER_GROUP_NAME" { | ||
| type = "string" | ||
| default = "" | ||
| description = "Existed paramater group name to use" |
There was a problem hiding this comment.
Existing parameter group name to use
aws/backing-services/rds.tf
Outdated
| subnet_ids = ["${module.subnets.private_subnet_ids}"] | ||
| vpc_id = "${module.vpc.vpc_id}" | ||
| snapshot_identifier = "${var.RDS_SNAPSHOT}" | ||
| auto_minor_version_upgrade = "false" |
aws/backing-services/rds.tf
Outdated
| vpc_id = "${module.vpc.vpc_id}" | ||
| snapshot_identifier = "${var.RDS_SNAPSHOT}" | ||
| auto_minor_version_upgrade = "false" | ||
| allow_major_version_upgrade = "false" |
There was a problem hiding this comment.
parameterize? (some users have been asking to be able to parameterize it)
aws/backing-services/rds.tf
Outdated
|
|
||
| output "rds_root_user" { | ||
| value = "${var.RDS_ADMIN_NAME}" | ||
| description = "RDS root name" |
aknysh
left a comment
aknysh
left a comment
There was a problem hiding this comment.
see comments.
also, let's rename the file to aws/backing-services/rds-mysql.tf since it's just for MySQL and we could have other RDS databases
No. The same |
aws/backing-services/rds.tf
Outdated
| enabled = "${var.RDS_ENABLED}" | ||
| namespace = "${var.namespace}" | ||
| stage = "${var.stage}" | ||
| name = "rds" |
There was a problem hiding this comment.
let's add and use variable name here
What
Why