Skip to content

[aws/artifacts] Add S3 bucket for storage #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 8, 2019
Merged

[aws/artifacts] Add S3 bucket for storage #54

merged 12 commits into from
Jan 8, 2019

Conversation

@osterman
Copy link
Member

@osterman osterman commented Dec 15, 2018 •
edited
Loading

what

  • Add S3 artifact storage as a website bucket with CloudFront (and CloudFlare) acceleration

why

  • For various artifacts from CI/CD (e.g. lambda zips)

aknysh
aknysh reviewed Dec 15, 2018
View reviewed changes
aknysh
aknysh reviewed Dec 15, 2018
View reviewed changes
@aknysh @osterman
Update aws/artifacts/variables.tf
df27ebd 
Co-Authored-By: osterman <erik@cloudposse.com>
aknysh
aknysh reviewed Dec 15, 2018
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
needs terraform fmt

@osterman osterman requested a review from aknysh December 15, 2018 04:51
aknysh
aknysh reviewed Dec 15, 2018
View reviewed changes
aknysh
aknysh reviewed Dec 15, 2018
View reviewed changes
aknysh
aknysh reviewed Dec 15, 2018
View reviewed changes
aknysh
aknysh reviewed Dec 15, 2018
View reviewed changes
aknysh
aknysh reviewed Dec 15, 2018
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, more comments

@osterman osterman requested a review from aknysh December 15, 2018 06:08
aknysh
aknysh reviewed Dec 16, 2018
View reviewed changes
aknysh
aknysh reviewed Dec 16, 2018
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@osterman osterman requested a review from aknysh December 17, 2018 01:14
@osterman
Copy link
Member Author

osterman commented Dec 17, 2018 •
edited
Loading

@aknysh need your help to triage some bug with the CDN module.

Everytime I apply this, it flipflops the DNS.

broken example

Here it tries to point the DNS of the alias to the s3 website instead of the DNS of the CDN distribution.

alias.876973354.name:                                         "d1ct9e0lav3q4y.cloudfront.net" => ""
alias.701075612.name:                                         "" => "s3-website-us-west-2.amazonaws.com"

working example

Here it correctly tries to set the DNS to that of the CDN distribution.

alias.701075612.name: "s3-website-us-west-2.amazonaws.com" => ""
alias.876973354.name: "" => "d1ct9e0lav3q4y.cloudfront.net"

references

@osterman
Copy link
Member Author

osterman commented Dec 20, 2018

@aknysh bump

@osterman osterman changed the title [artifacts] Add S3 bucket for storage [aws/artifacts] Add S3 bucket for storage Dec 23, 2018
@osterman osterman merged commit df36135 into master Jan 8, 2019
@osterman osterman deleted the add-artifacts branch January 8, 2019 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goruha goruha goruha approved these changes

@joshmyers joshmyers Awaiting requested review from joshmyers

@aknysh aknysh Awaiting requested review from aknysh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@osterman @goruha @aknysh