Skip to content

Conversation

@Nuru
Copy link
Contributor

@Nuru Nuru commented May 4, 2023

what

  • Fix bug in aws-config
  • Enhance documentation to explain relationship of dns-primary and dns-delegated components and dns account
  • [eks/actions-runner-controller] Add support for annotations and improve support for ephemeral storage

why

references

@Nuru Nuru requested review from a team as code owners May 4, 2023 05:56
mcalhoun
mcalhoun previously approved these changes May 4, 2023
Copy link
Contributor

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few comments

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@Nuru Nuru merged commit 2a0dca8 into master May 4, 2023
@Nuru Nuru deleted the aws-config branch May 4, 2023 23:04
goruha pushed a commit to cloudposse-terraform-components/aws-dns-primary that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-actions-runner-controller that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants