Skip to content

Conversation

@aknysh
Copy link
Member

@aknysh aknysh commented Jun 4, 2018

what

  • Remove dependencies on terraform-aws-account-metadata
  • Use Terraform vars instead (which could be be provided from Dockerfile or chamber)

why

  • Maketerraform-root-modules a generic Terraform module that could be used for different projects (including third-party) and for Cloud Posse documentation
  • terraform-aws-account-metadata is a private repo and contains secrets
  • Eliminate cold-start cycles
  • Fewer repos to maintain

@aknysh aknysh self-assigned this Jun 4, 2018
@aknysh aknysh requested review from goruha, osterman and sarkis June 4, 2018 22:25
@osterman
Copy link
Member

osterman commented Jun 5, 2018

I think this is a good change.

@aknysh aknysh merged commit 9fd29a6 into master Jun 5, 2018
@aknysh aknysh deleted the remove-account-metadata-deps branch June 5, 2018 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants