Skip to content

Lambda kms policy #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 1, 2021
Merged

Lambda kms policy #10

merged 6 commits into from
Sep 1, 2021

Conversation

@bwmetcalf
Copy link
Contributor

@bwmetcalf bwmetcalf commented Sep 1, 2021 •
edited
Loading

what

  • Add ability to pass in extra iam policy for lambda role

why

  • If the datadog api key is encrypted in secrets manager, lambda also needs access to the kms key used to encrypt said key

references

@bwmetcalf bwmetcalf requested review from a team as code owners September 1, 2021 12:36
@bwmetcalf bwmetcalf requested a review from a team as a code owner September 1, 2021 12:37
@bwmetcalf bwmetcalf requested review from 3h4x and Makeshift September 1, 2021 12:37
nitrocode
nitrocode reviewed Sep 1, 2021
View reviewed changes
@bwmetcalf
Copy link
Contributor Author

bwmetcalf commented Sep 1, 2021

@nitrocode Thanks for deleting that extra var reference. Oversight on my part.

@nitrocode nitrocode merged commit 864b68c into cloudposse:master Sep 1, 2021
@nitrocode
Copy link
Member

nitrocode commented Sep 1, 2021

Thanks @bwmetcalf !

@nitrocode nitrocode mentioned this pull request Sep 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift

@3h4x 3h4x Awaiting requested review from 3h4x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lambda role policy requires kms:Decrypt

3 participants

@bwmetcalf @nitrocode @cloudpossebot