Integrate Sentry#342
Merged
roneli merged 11 commits intocloudquery:mainfrom Dec 15, 2021
Merged
Conversation
yevgenypats
previously requested changes
Dec 14, 2021
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Where is the opt-out flag?
Member
Author
oops. added. |
spangenberg
approved these changes
Dec 14, 2021
roneli
suggested changes
Dec 15, 2021
Contributor
roneli
left a comment
roneli
left a comment
There was a problem hiding this comment.
Would also suggest to do some manual tests like running AWS provider with bad credentials
Also write some tests for example test provider and see that errors get captured and sent.
For AWS provider I would test that the no creds are leaked, they shouldn't but just to double check.
…ions (ie. telemetry-debug)
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
🤖 I have created a release *beep* *boop* --- ## [0.11.8](cloudquery/cq-provider-azure@v0.11.7...v0.11.8) (2022-06-14) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.1 ([#340](cloudquery/cq-provider-azure#340)) ([77c7e50](cloudquery/cq-provider-azure@77c7e50)) * Panic in `security.jit_network_access_policies` ([#342](cloudquery/cq-provider-azure#342)) ([3604559](cloudquery/cq-provider-azure@3604559)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
If one of the goroutines spawned in listBigqueryDatasetTables fails and returns an error then errgroup.Group.Go will cancel the context. Then semaphore.Acquire can fail because of the canceled context. After this resolver finishes, and the SDK closes results channel. But other spawned goroutines can still be running and they may try to send through this closed channel. Panic.
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
🤖 I have created a release *beep* *boop* --- ## [0.8.13](cloudquery/cq-provider-gcp@v0.8.12...v0.8.13) (2022-06-15) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.2 ([#343](cloudquery/cq-provider-gcp#343)) ([397ccdb](cloudquery/cq-provider-gcp@397ccdb)) * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.3 ([#345](cloudquery/cq-provider-gcp#345)) ([8a67f71](cloudquery/cq-provider-gcp@8a67f71)) * Possible panic ([#342](cloudquery/cq-provider-gcp#342)) ([3e0a72d](cloudquery/cq-provider-gcp@3e0a72d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What more do we need?