Skip to content

Prevent reporting of errors to Sentry twice#386

Merged
yevgenypats merged 1 commit intocloudquery:mainfrom
disq:fix/double-sentry-errors
Jan 4, 2022
Merged

Prevent reporting of errors to Sentry twice#386
yevgenypats merged 1 commit intocloudquery:mainfrom
disq:fix/double-sentry-errors

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Jan 4, 2022

Once in end of span (with spanEnder business) and the other in the cli handler.

Once in end of span (with `spanEnder` business) and the other in the cli handler.
@disq disq requested a review from roneli January 4, 2022 15:41
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, shame no way to actually test this

@yevgenypats yevgenypats merged commit e23bc65 into cloudquery:main Jan 4, 2022
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
…13.2 (#386)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/cloudquery/cq-provider-sdk](https://togithub.com/cloudquery/cq-provider-sdk) | require | patch | `v0.13.1` -> `v0.13.2` |

---

### Release Notes

<details>
<summary>cloudquery/cq-provider-sdk</summary>

### [`v0.13.2`](https://togithub.com/cloudquery/cq-provider-sdk/releases/tag/v0.13.2)

[Compare Source](https://togithub.com/cloudquery/cq-provider-sdk/compare/v0.13.1...v0.13.2)

##### Bug Fixes

-   Use 'cur' ulimit in calculation, not 'max' ([#&#8203;399](https://togithub.com/cloudquery/cq-provider-sdk/issues/399)) ([1acc3de](https://togithub.com/cloudquery/cq-provider-sdk/commit/1acc3decc40b532be13906713f9e3f7bb905b63b))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.8.23](cloudquery/cq-provider-gcp@v0.8.22...v0.8.23) (2022-07-03)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.13.2 ([#386](cloudquery/cq-provider-gcp#386)) ([e776010](cloudquery/cq-provider-gcp@e776010))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.11.20](cloudquery/cq-provider-azure@v0.11.19...v0.11.20) (2022-07-03)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.13.2 ([#385](cloudquery/cq-provider-azure#385)) ([2acb762](cloudquery/cq-provider-azure@2acb762))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants