Merged
Conversation
disq
commented
Jun 19, 2023
erezrokah
approved these changes
Jun 26, 2023
disq
commented
Jun 27, 2023
| if !isTypeSupported(f.Type) { | ||
| fields[i].Type = arrow.BinaryTypes.String | ||
| } | ||
| fields[i].Metadata = stripCQExtensionMetadata(fields[i].Metadata) |
Member
Author
There was a problem hiding this comment.
This call is required for the csv writer to actually write the records, on write it compares the schema given to the csv.NewWriter with the record schema, which (in our case) turns out to be slightly different and missing the cq:extension:* things. So we strip them here from both places (since they don't hold any actionable info for csv writing)
disq
commented
Jun 27, 2023
| "github.com/google/uuid" | ||
| ) | ||
|
|
||
| func TestWrite(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
This test case was removed because TestWriteRead has the write functionality (and t.Log can be added for debugging if necessary)
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](v3.2.0...v4.0.0) (2023-06-29) ### ⚠ BREAKING CHANGES * Upgrade to plugin-sdk v4 ([#210](#210)) ### Features * Upgrade to plugin-sdk v4 ([#210](#210)) ([fae0de7](fae0de7)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 0656028 ([#221](#221)) ([a655381](a655381)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 1e68c51 ([#206](#206)) ([8e7e907](8e7e907)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 43638cb ([#212](#212)) ([8322675](8322675)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 95d3199 ([#214](#214)) ([9a796ab](9a796ab)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 9a09f72 ([#207](#207)) ([9c03e62](9c03e62)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to b0832be ([#209](#209)) ([367439f](367439f)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to d01ed41 ([#208](#208)) ([0c447ec](0c447ec)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to d864719 ([#204](#204)) ([5c6d9e9](5c6d9e9)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f0dffc6 ([#213](#213)) ([c567381](c567381)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.1.0 ([#211](#211)) ([639a9da](639a9da)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.0 ([#215](#215)) ([c53fde4](c53fde4)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.1 ([#216](#216)) ([9dc8b34](9dc8b34)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.0 ([#217](#217)) ([41f7037](41f7037)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.2 ([#218](#218)) ([f57d43e](f57d43e)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.2 ([#219](#219)) ([a7e12d8](a7e12d8)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.3 ([#220](#220)) ([f4d8d70](f4d8d70)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.4 ([#222](#222)) ([59602c3](59602c3)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.5 ([#223](#223)) ([e9de9df](e9de9df)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.6 ([#224](#224)) ([76d44ba](76d44ba)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.4.0 ([#225](#225)) ([b5f44e2](b5f44e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.