Skip to content

feat: Change option name #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Jan 27, 2023
Merged

feat: Change option name #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3af72e
Update client.go
bbernays Jan 27, 2023
206b664
Update spec.go
bbernays Jan 27, 2023
8257c5b
Update spec_test.go
bbernays Jan 27, 2023
43c1f17
skip_header
bbernays Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func NewClient(spec *FileSpec) (*Client, error) {
opts := []csvFile.Options{
csvFile.WithDelimiter([]rune(spec.csvSpec.Delimiter)[0]),
}
if spec.csvSpec.IncludeHeaders {
if !spec.csvSpec.SkipHeader {
opts = append(opts, csvFile.WithHeader())
}

Expand Down
4 changes: 2 additions & 2 deletions csv/spec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package csv
import "fmt"

type Spec struct {
IncludeHeaders bool `json:"include_headers,omitempty"`
Delimiter string `json:"delimiter,omitempty"`
SkipHeader bool `json:"skip_header,omitempty"`
Delimiter string `json:"delimiter,omitempty"`
}

func (s *Spec) SetDefaults() {
Expand Down
24 changes: 12 additions & 12 deletions spec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,25 @@ func TestSpecMethods(t *testing.T) {
},
preDefaultsCSV: &csv.Spec{},
postDefaultsCSV: &csv.Spec{
IncludeHeaders: false,
Delimiter: ",",
SkipHeader: false,
Delimiter: ",",
},
},
{
FileSpec: &FileSpec{
Format: FormatTypeCSV,
FormatSpec: map[string]any{
"delimiter": ",",
"include_headers": true,
"delimiter": ",",
"skip_header": true,
},
},
preDefaultsCSV: &csv.Spec{
IncludeHeaders: true,
Delimiter: ",",
SkipHeader: true,
Delimiter: ",",
},
postDefaultsCSV: &csv.Spec{
IncludeHeaders: true,
Delimiter: ",",
SkipHeader: true,
Delimiter: ",",
},
},
{
Expand All @@ -51,12 +51,12 @@ func TestSpecMethods(t *testing.T) {
FormatSpec: map[string]any{},
},
preDefaultsCSV: &csv.Spec{
IncludeHeaders: false,
Delimiter: "",
SkipHeader: false,
Delimiter: "",
},
postDefaultsCSV: &csv.Spec{
IncludeHeaders: false,
Delimiter: ",",
SkipHeader: false,
Delimiter: ",",
},
},
{
Expand Down