Skip to content

feat: Add more error handling to downloading Hub plugins #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Oct 5, 2023
Merged

feat: Add more error handling to downloading Hub plugins #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3173dc
feat: Add more error handling to downloading Hub plugins
erezrokah Oct 5, 2023
9b90f44
Merge branch 'main' into feat/more_error_handling
kodiakhq[bot] Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions managedplugin/download.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ func DownloadPluginFromHub(ctx context.Context, localPath string, team string, n
if downloadURL.StatusCode == http.StatusNotFound {
return fmt.Errorf("failed to get plugin url for %v %v/%v@%v: plugin version not found", typ, team, name, version)
}
if downloadURL.StatusCode == http.StatusTooManyRequests {
return fmt.Errorf("failed to get plugin url for %v %v/%v@%v: too many requests. Try logging in via `cloudquery login` to increase rate limits", typ, team, name, version)
}
if downloadURL.StatusCode != http.StatusFound {
return fmt.Errorf("failed to get plugin url for %v %v/%v@%v: unexpected status code %v", typ, team, name, version, downloadURL.StatusCode)
}
location, ok := downloadURL.Header["Location"]
if !ok {
return fmt.Errorf("failed to get plugin url for %v %v/%v@%v: missing location header from response", typ, team, name, version)
Expand Down