Skip to content

fix: Fix JSON type handling #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix: Fix JSON type handling #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cloudquery/sdk/scalar/scalar_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from .date64 import Date64
from .float import Float
from .int import Int
from .json import JSON
from .list import List
from .scalar import ScalarInvalidTypeError
from .string import String
Expand Down Expand Up @@ -89,6 +90,6 @@ def new_scalar(self, dt: pa.DataType):
elif dt == UUIDType():
return UUID()
elif dt == JSONType():
return String()
return JSON()
else:
raise ScalarInvalidTypeError("Invalid type {} for scalar".format(dt))
1 change: 0 additions & 1 deletion cloudquery/sdk/scalar/string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from cloudquery.sdk.scalar import Scalar, ScalarInvalidTypeError
from .scalar import NULL_VALUE


class String(Scalar):
Expand Down