Skip to content

feat: Add support for no_connection param to init #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023
Merged

feat: Add support for no_connection param to init #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cloudquery/sdk/internal/servers/plugin_v3/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
from typing import Generator

import pyarrow as pa
import structlog

from typing import Generator
from cloudquery.plugin_v3 import plugin_pb2, plugin_pb2_grpc, arrow

from cloudquery.sdk.message import (
SyncInsertMessage,
SyncMigrateTableMessage,
Expand All @@ -27,7 +28,7 @@ def GetVersion(self, request, context):
return plugin_pb2.GetVersion.Response(version=self._plugin.version())

def Init(self, request: plugin_pb2.Init.Request, context):
self._plugin.init(request.spec)
self._plugin.init(request.spec, no_connection=request.no_connection)
return plugin_pb2.Init.Response()

def GetTables(self, request: plugin_pb2.GetTables.Request, context):
Expand Down
5 changes: 2 additions & 3 deletions cloudquery/sdk/plugin/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import queue
from dataclasses import dataclass
from typing import List, Generator

from cloudquery.sdk.schema import Table
from cloudquery.sdk import message
from cloudquery.sdk.schema import Table

MIGRATE_MODE_STRINGS = ["safe", "force"]

Expand Down Expand Up @@ -35,7 +34,7 @@ def __init__(self, name: str, version: str) -> None:
self._name = name
self._version = version

def init(self, spec: bytes) -> None:
def init(self, spec: bytes, no_connection: bool = False) -> None:
pass

def set_logger(self, logger) -> None:
Expand Down