Skip to content

Conversation

@candiduslynx
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 30, 2023

⏱️ Benchmark results

  • DefaultConcurrencyDFS-2 resources/s: 11,185
  • DefaultConcurrencyRoundRobin-2 resources/s: 10,845
  • Glob-2 ns/op: 201.8
  • TablesWithChildrenDFS-2 resources/s: 26,971
  • TablesWithChildrenRoundRobin-2 resources/s: 27,351
  • TablesWithRateLimitingDFS-2 resources/s: 28.26
  • TablesWithRateLimitingRoundRobin-2 resources/s: 838.5
  • BufferedScanner-2 ns/op: 9.382
  • LogReader-2 ns/op: 30.76

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (b07fd22) 47.18% compared to head (651ecb3) 47.14%.

❗ Current head 651ecb3 differs from pull request most recent head d5a30d8. Consider uploading reports for the commit d5a30d8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   47.18%   47.14%   -0.05%     
==========================================
  Files          76       76              
  Lines        7841     7853      +12     
==========================================
+ Hits         3700     3702       +2     
- Misses       3642     3651       +9     
- Partials      499      500       +1     
Impacted Files Coverage Δ
schema/arrow.go 13.09% <0.00%> (-0.30%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled now here - #832

@candiduslynx
Copy link
Contributor Author

This should be handled now here - #832

@yevgenypats I've looked through the #832 and didn't find the incremental & PK constraint handling.

@candiduslynx candiduslynx requested a review from yevgenypats May 2, 2023 05:59
@kodiakhq kodiakhq bot merged commit 95a9f0c into main May 4, 2023
@kodiakhq kodiakhq bot deleted the fix/constraints-for-arrow-from-schema branch May 4, 2023 10:37
kodiakhq bot pushed a commit that referenced this pull request May 4, 2023
🤖 I have created a release *beep* *boop*
---


## [2.5.3](v2.5.2...v2.5.3) (2023-05-04)


### Bug Fixes

* **arrow:** Add missing table options ([#833](#833)) ([95a9f0c](95a9f0c))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants