refactor(writers): Don't leak timers

[disq]

Alternative to #1058

[hermanschaaf]

I haven't looked into it yet, but what does time.Ticker do if you pass in a 0 duration? If that works, maybe we can simplify by using that?

[disq]

I haven't looked into it yet, but what does time.Ticker do if you pass in a 0 duration? If that works, maybe we can simplify by using that?

Looks like it will fire immediately (after a certain unspecified) delay:

func when(d Duration) int64 {
	if d <= 0 {
		return runtimeNano()
	}

[disq]

We could also use .Reset(time.Duration) to re-use the same timer over and over again, would require a follow-up PR though... cc @candiduslynx

[candiduslynx]

you shouldn't need to manually close on every iteration

[disq]

incoming commit:

type ticker interface {
	Chan() <-chan time.Time
	Reset(time.Duration)
	Stop() bool
}

[candiduslynx]

@disq WDYT about e63bc5e instead?