refactor(ticker): Don't reset manually

[candiduslynx]

Follow-up for #1056

[hermanschaaf]

What is this fixing?

[hermanschaaf]

It seems to me like the other code used to handle a 0 timeout, but this doesn't (I'm not sure what ticker's behavior is if it's passed 0). We don't have tests for that case in these two batch writers right now, but I think a better fix here would be to add a test for a 0 timeout?

[disq]

Not supporting a zero/disabled batchtimeout doesn't sit well with the file destinations (with NoRotate or path patterns without UUID).

[candiduslynx]

@hermanschaaf @disq
https://pkg.go.dev/time#Tick
https://cs.opensource.google/go/go/+/refs/tags/go1.20.5:src/time/tick.go;l=68
The impl will ret nil just like the manual implementation that's now removed:

// Tick is a convenience wrapper for NewTicker providing access to the ticking
// channel only. While Tick is useful for clients that have no need to shut down
// the Ticker, be aware that without a way to shut it down the underlying
// Ticker cannot be recovered by the garbage collector; it "leaks".
// Unlike NewTicker, Tick will return nil if d <= 0.
func Tick(d Duration) <-chan Time {
	if d <= 0 {
		return nil
	}
	return NewTicker(d).C
}

[disq]

Missing the fix for streamingbatchwriter :)

[hermanschaaf]

Isn't the leak mentioned in the comment of time.Tick also something consider here?

[disq]

Isn't the leak mentioned in the comment of time.Tick also something consider here?

I think it is if we're going to have long running writers.

[candiduslynx]

Fixed leak in e63bc5e

[disq]

Same ticker will be used for all writers, maybe move this to the upper writers package? We use MsgID from that as well.

[candiduslynx]

@disq

Same ticker will be used for all writers, maybe move this to the upper writers package? We use MsgID from that as well.

Done in 68015d3

Missing the fix for streamingbatchwriter :)

Done in 8f241a0