feat: Test that JSON columns don't receive string values #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
changed the title
erezrokah
approved these changes
Sep 21, 2022
yevgenypats
approved these changes
Sep 21, 2022
hermanschaaf
pushed a commit
that referenced
this pull request
Sep 21, 2022
🤖 I have created a release *beep* *boop* --- ## [0.7.11](v0.7.10...v0.7.11) (2022-09-21) ### Features * Test that JSON columns don't receive string values ([#156](#156)) ([d730fdb](d730fdb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Sep 21, 2022
Fixes issues identified by cloudquery/plugin-sdk#156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches a new class of bug where an already-marshalled string or byte-slice gets passed to a JSON column. This results in string that gets doubly-marshalled, which is not the intention. Instead, either the unmarshalled object should be passed in, or the column type should be changed to string.