Skip to content

fix(test): Values check test should account for IgnoreInTests column option #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 6 commits into from
Nov 25, 2022
Merged

fix(test): Values check test should account for IgnoreInTests column option #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1bb149
ignore in tests should be accounted for values chack
candiduslynx Nov 24, 2022
786296b
add test
candiduslynx Nov 24, 2022
2966eff
test positive & negative
candiduslynx Nov 24, 2022
9ddf19e
allow passing tests
candiduslynx Nov 24, 2022
782e004
ret old signature
candiduslynx Nov 24, 2022
5ef5e7a
ease if
candiduslynx Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions plugins/source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,3 +296,18 @@ func testSyncTable(t *testing.T, tc syncTestCase) {
t.Fatal(err)
}
}

func TestIgnoredColumns(t *testing.T) {
validateResources(t, schema.Resources{{
Item: struct{ A *string }{},
Table: &schema.Table{
Columns: schema.ColumnList{
{
Name: "a",
Type: schema.TypeString,
IgnoreInTests: true,
},
},
},
}})
}
4 changes: 3 additions & 1 deletion plugins/source_testing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ func validateResources(t *testing.T, resources []*schema.Resource) {

// Make sure every column has at least one value.
for i, hasValue := range columnsWithValues {
if !hasValue && !(table.Columns[i].Name == "_cq_parent_id" && table.Parent == nil) {
col := table.Columns[i]
emptyExpected := col.Name == "_cq_parent_id" && table.Parent == nil
if !hasValue && !emptyExpected && !col.IgnoreInTests {
t.Errorf("table: %s column %s has no values", table.Name, table.Columns[i].Name)
}
}
Expand Down