Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint_markdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Vale
uses: errata-ai/vale-action@v2
with:
vale_flags: "--glob=!{plugins/source/.snapshots/*,CHANGELOG.md,.github/styles/proselint/README.md}"
vale_flags: "--glob=!{plugins/source/testdata/*,CHANGELOG.md,.github/styles/proselint/README.md}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to ignore it a in the lint-structure job too. It probably ignored it by default being a . file

filter_mode: nofilter
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
Expand All @@ -29,4 +29,4 @@ jobs:
with:
files: .
config_file: .markdownlint.yaml
ignore_files: "CHANGELOG.md"
ignore_files: '{plugins/source/testdata/*,CHANGELOG.md}'
6 changes: 4 additions & 2 deletions plugins/source/docs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ var testTables = []*schema.Table{
func TestGeneratePluginDocs(t *testing.T) {
p := NewPlugin("test", "v1.0.0", testTables, newTestExecutionClient)

cup := cupaloy.New(cupaloy.SnapshotSubdirectory("testdata"))

t.Run("Markdown", func(t *testing.T) {
tmpdir := t.TempDir()

Expand All @@ -117,7 +119,7 @@ func TestGeneratePluginDocs(t *testing.T) {
output := path.Join(tmpdir, exp)
got, err := os.ReadFile(output)
require.NoError(t, err)
cupaloy.SnapshotT(t, got)
cup.SnapshotT(t, got)
})
}
})
Expand All @@ -136,7 +138,7 @@ func TestGeneratePluginDocs(t *testing.T) {
output := path.Join(tmpdir, exp)
got, err := os.ReadFile(output)
require.NoError(t, err)
cupaloy.SnapshotT(t, got)
cup.SnapshotT(t, got)
})
}
})
Expand Down