Skip to content

Conversation

@disq
Copy link
Member

@disq disq commented Apr 17, 2023

Committing dotfiles give me the creeps.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (1320d32) 46.65% compared to head (958ad88) 46.66%.

❗ Current head 958ad88 differs from pull request most recent head bd3d335. Consider uploading reports for the commit bd3d335 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
+ Coverage   46.65%   46.66%   +0.01%     
==========================================
  Files          76       76              
  Lines        7823     7821       -2     
==========================================
  Hits         3650     3650              
+ Misses       3682     3680       -2     
  Partials      491      491              

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

⏱️ Benchmark results

  • DefaultConcurrencyDFS-2 resources/s: 10,686
  • DefaultConcurrencyRoundRobin-2 resources/s: 11,124
  • Glob-2 ns/op: 187.4
  • TablesWithChildrenDFS-2 resources/s: 27,923
  • TablesWithChildrenRoundRobin-2 resources/s: 29,272
  • TablesWithRateLimitingDFS-2 resources/s: 28.06
  • TablesWithRateLimitingRoundRobin-2 resources/s: 863.1
  • BufferedScanner-2 ns/op: 9.399
  • LogReader-2 ns/op: 30.69

uses: errata-ai/vale-action@v2
with:
vale_flags: "--glob=!{plugins/source/.snapshots/*,CHANGELOG.md,.github/styles/proselint/README.md}"
vale_flags: "--glob=!{plugins/source/testdata/*,CHANGELOG.md,.github/styles/proselint/README.md}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to ignore it a in the lint-structure job too. It probably ignored it by default being a . file

@kodiakhq kodiakhq bot merged commit fb2929f into cloudquery:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants