Skip to content

Conversation

@erezrokah
Copy link
Member

Summary

Same as cloudquery/cloudquery#10276


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests πŸ§ͺ
  • Ensure the status checks below are successful βœ…

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (4cd3872) 47.19% compared to head (bd30726) 47.04%.

❗ Current head bd30726 differs from pull request most recent head ead94fe. Consider uploading reports for the commit ead94fe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   47.19%   47.04%   -0.15%     
==========================================
  Files          76       76              
  Lines        7844     7858      +14     
==========================================
- Hits         3702     3697       -5     
- Misses       3642     3670      +28     
+ Partials      500      491       -9     

see 7 files with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Apr 24, 2023

⏱️ Benchmark results

Comparing with e9f29ff

  • DefaultConcurrencyDFS-2 resources/s: 10,438 ⬇️ 5.82% decrease vs. e9f29ff
  • DefaultConcurrencyRoundRobin-2 resources/s: 11,012 ⬇️ 9.81% decrease vs. e9f29ff
  • Glob-2 ns/op: 279.7 ⬆️ 28.75% increase vs. e9f29ff
  • TablesWithChildrenDFS-2 resources/s: 23,637 ⬇️ 14.61% decrease vs. e9f29ff
  • TablesWithChildrenRoundRobin-2 resources/s: 24,248 ⬇️ 8.43% decrease vs. e9f29ff
  • TablesWithRateLimitingDFS-2 resources/s: 28.46 ⬇️ 0.07% decrease vs. e9f29ff
  • TablesWithRateLimitingRoundRobin-2 resources/s: 845.1 ⬆️ 7.36% increase vs. e9f29ff
  • BufferedScanner-2 ns/op: 12.65 ⬆️ 25.84% increase vs. e9f29ff
  • LogReader-2 ns/op: 39.99 ⬆️ 22.86% increase vs. e9f29ff

@candiduslynx candiduslynx merged commit bc14251 into cloudquery:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants