This repository was archived by the owner on Mar 30, 2026. It is now read-only.
fix: Remove volume type variable, handle invalid index error#24
Merged
fix: Remove volume type variable, handle invalid index error#24
Conversation
Contributor
Contributor
|
Great idea regarding CI @erezrokah. I can look later this morning. |
mnorbury
reviewed
Feb 7, 2025
mnorbury
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Running
terraform planon the non tls examples gives the multiple'iops' must not be set when 'type' is 'gp2'errors.Setting:
solves that error only to get
Error: Invalid indexerrors.This PR fixes the issues by removing the volume type configurations and checking if encryption is enabled before accessing some arrays.
I think we should also run
terraform planin CI (see commented out code), but we need to set up a role for it. How do we usually do that? I don't want to manually create it