Skip to content
This repository was archived by the owner on Mar 30, 2026. It is now read-only.

fix: Remove volume type variable, handle invalid index error#24

Merged
mnorbury merged 5 commits intomainfrom
fix/remove_volume_type
Feb 7, 2025
Merged

fix: Remove volume type variable, handle invalid index error#24
mnorbury merged 5 commits intomainfrom
fix/remove_volume_type

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Feb 7, 2025

Running terraform plan on the non tls examples gives the multiple 'iops' must not be set when 'type' is 'gp2' errors.
Setting:

 clickhouse_volume_type   = "gp3"
 keeper_volume_type      = "gp3"

solves that error only to get Error: Invalid index errors.

This PR fixes the issues by removing the volume type configurations and checking if encryption is enabled before accessing some arrays.

I think we should also run terraform plan in CI (see commented out code), but we need to set up a role for it. How do we usually do that? I don't want to manually create it

@erezrokah erezrokah requested review from a team, mnorbury and rebelopsio February 7, 2025 13:05
@erezrokah erezrokah changed the title fix: Remove volume type, handle invalid index error fix: Remove volume type variable, handle invalid index error Feb 7, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2025

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 9
LOW LOW 13
INFO INFO 8
TRACE TRACE 0
TOTAL TOTAL 30
Metric Values
Files scanned placeholder 20
Files parsed placeholder 20
Files failed to scan placeholder 0
Total executed queries placeholder 1043
Queries failed to execute placeholder 19
Execution time placeholder 28

@rebelopsio
Copy link
Copy Markdown
Contributor

Great idea regarding CI @erezrokah. I can look later this morning.

Comment thread clickhouse/ebs.tf Outdated
@mnorbury mnorbury merged commit 947f285 into main Feb 7, 2025
@mnorbury mnorbury deleted the fix/remove_volume_type branch February 7, 2025 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants