Skip to content

Allow to set API URL by ENV#8

Merged
resmo merged 4 commits intomasterfrom
feature/endpoint_by_env
Sep 24, 2020
Merged

Allow to set API URL by ENV#8
resmo merged 4 commits intomasterfrom
feature/endpoint_by_env

Conversation

@resmo
Copy link
Collaborator

@resmo resmo commented Sep 22, 2020

No description provided.

@resmo resmo requested a review from href September 24, 2020 13:30
Copy link

@href href left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - as requested you should just change the name to CLOUDSCALE_API_URL, to be consistent across projects.

@resmo resmo changed the title Allow to set API endpoint by ENV Allow to set API URL by ENV Sep 24, 2020
@resmo resmo requested a review from href September 24, 2020 14:34
Copy link

@href href left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@resmo resmo merged commit 8d3a47a into master Sep 24, 2020
@resmo resmo deleted the feature/endpoint_by_env branch September 24, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants